Stephen Hemminger
2004-01-20 23:20:20 UTC
My Sony Clié SJ33 can not attach the memory card unless the following patch is added
to 2.6.1. The problem is that the PDA does not follow the storage spec's and the
code was being too picky.
I sent the same patch in before but it didn't make it in.
diff -urN -X /home/shemminger/osdlab/dontdiff linux-2.5/drivers/usb/storage/transport.c desktop-2.5/drivers/usb/storage/transport.c
--- linux-2.5/drivers/usb/storage/transport.c 2004-01-16 15:18:45.000000000 -0800
+++ desktop-2.5/drivers/usb/storage/transport.c 2004-01-20 14:25:58.000000000 -0800
@@ -819,6 +819,8 @@
return USB_STOR_TRANSPORT_GOOD;
}
+#if 0
+ /* Removed because some devices do not follow the spec. */
/* If not UFI, we interpret the data as a result code
* The first byte should always be a 0x0
* The second byte & 0x0F should be 0x0 for good, otherwise error
@@ -828,6 +830,7 @@
us->iobuf[0]);
return USB_STOR_TRANSPORT_ERROR;
}
+#endif
switch (us->iobuf[1] & 0x0F) {
case 0x00:
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
linux-usb-***@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
to 2.6.1. The problem is that the PDA does not follow the storage spec's and the
code was being too picky.
I sent the same patch in before but it didn't make it in.
diff -urN -X /home/shemminger/osdlab/dontdiff linux-2.5/drivers/usb/storage/transport.c desktop-2.5/drivers/usb/storage/transport.c
--- linux-2.5/drivers/usb/storage/transport.c 2004-01-16 15:18:45.000000000 -0800
+++ desktop-2.5/drivers/usb/storage/transport.c 2004-01-20 14:25:58.000000000 -0800
@@ -819,6 +819,8 @@
return USB_STOR_TRANSPORT_GOOD;
}
+#if 0
+ /* Removed because some devices do not follow the spec. */
/* If not UFI, we interpret the data as a result code
* The first byte should always be a 0x0
* The second byte & 0x0F should be 0x0 for good, otherwise error
@@ -828,6 +830,7 @@
us->iobuf[0]);
return USB_STOR_TRANSPORT_ERROR;
}
+#endif
switch (us->iobuf[1] & 0x0F) {
case 0x00:
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
linux-usb-***@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel